[discovery] Refactor java.util.Date usages to java.time.Instant
#4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
force-pushed
the
config-discovery-date
branch
from
ead984c
to
6218ca6
Compare
J-N-K
approved these changes
Jan 7, 2024
jlaur
commented
Jan 8, 2024
| @@ -43,7 +43,7 @@ public class DiscoveryResultImpl implements DiscoveryResult { | |||
| private @Nullable String representationProperty; | |||
| private @NonNullByDefault({}) DiscoveryResultFlag flag; | |||
| private @NonNullByDefault({}) String label; | |||
| private long timestamp; | |||
| private Instant timestamp = Instant.MIN; | |||
There was a problem hiding this comment.
@J-N-K - unfortunately I ran into this nasty regression today a moment ago:
2024-01-08 21:43:22.754 [ERROR] [re.storage.json.internal.JsonStorage] - Couldn't deserialize value 'org.openhab.core.storage.json.internal.StorageEntry@3df4a8fa'. Root cause is: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was NUMBER at path $.timestamp
so now realize that this object is deserialized from the JSON file userdata/org.openhab.core.config.discovery.DiscoveryResult.json.
The easy solution is to revert this variable back to long. Alternately we can keep Instant, but implement custom deserialization that can handle both. WDYT? Right at this moment I'm not sure where this is deserialized.
jlaur
added a commit
to jlaur/openhab-core
that referenced
this pull request
Jan 8, 2024
Partially revert openhab#4026 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
|
Write a converter for the JSON storage. |
cipianpascu
pushed a commit
to cipianpascu/openhab-core
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors some java.util.Date usages to the more modern time API.
The API is preserved as epoch milliseconds, so this is a non-breaking change.
There is two user-facing changes, though.
Previously this would be displayed like this:
Since this is already quite technical, I didn't see a reason to invest in preserving the old formatting.
This is now UTC-formatted: