Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config parsing and version handling in RemoteAddonServices #4043

Merged
merged 2 commits into from Jan 15, 2024
Merged

Fix config parsing and version handling in RemoteAddonServices #4043

merged 2 commits into from Jan 15, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 15, 2024

Closes #4031

@J-N-K
Fix config parsing in JsonAddonService
be5c0d6 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Jan 15, 2024
@J-N-K J-N-K requested a review from a team as a code owner January 15, 2024 17:57
@J-N-K
fix bundle version parsing
6a6b6a7 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of the Core and removed enhancement An enhancement or new feature of the Core labels Jan 15, 2024
@J-N-K J-N-K changed the title Improve config parsing in JsonAddonService Fix config parsing and version handling in RemoteAddonServices Jan 15, 2024
@J-N-K J-N-K mentioned this pull request Jan 15, 2024
Closed
wborn
wborn approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@wborn wborn merged commit d3d0fe3 into openhab:main Jan 15, 2024
3 checks passed
@wborn wborn added this to the 4.2 milestone Jan 15, 2024
@J-N-K J-N-K deleted the json2 branch January 16, 2024 16:28
@J-N-K
Copy link
Member Author

J-N-K commented Jan 16, 2024

I think this should also be cherry-picked to 4.1.x

@wborn
Copy link
Member

wborn commented Jan 16, 2024

Yes that would be nice!

cipianpascu pushed a commit to cipianpascu/openhab-core that referenced this pull request Jan 17, 2024
@J-N-K
Fix config parsing and version handling in RemoteAddonServices (openh…
89817bd 
…ab#4043)

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.2
2 participants
@J-N-K @wborn