Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddonFinderProcess fixes #4061

Merged
merged 12 commits into from
Jan 31, 2024
Merged

AddonFinderProcess fixes #4061

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7d3c575
AddonFinderProcess fixes
andrewfg Jan 23, 2024
876858b
change arg[0] => commandLine[0]; check for zero match-property's
andrewfg Jan 24, 2024
3686c7e
minor code optimisation
andrewfg Jan 24, 2024
8c84f95
work around for path/filenames with spaces
andrewfg Jan 24, 2024
7f70934
tweak commandLine parser; add conditional break
andrewfg Jan 25, 2024
98e198b
use string.join()
andrewfg Jan 25, 2024
a30f89e
adopt reviewer suggestion
andrewfg Jan 25, 2024
10758bb
eliminate index out of bounds
andrewfg Jan 25, 2024
c1acdbc
Merge branch 'openhab:main' into process-finder-fixes
andrewfg Jan 25, 2024
a16cd44
filter out all null entries
andrewfg Jan 26, 2024
1bcecf6
adopt reiewer suggestion
andrewfg Jan 29, 2024
641805a
adopt reviewer suggestion
andrewfg Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ess/src/main/java/org/openhab/core/config/discovery/addon/process/ProcessAddonFinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ public Set<AddonInfo> getSuggestedAddons() {

try {
processInfos = ProcessHandle.allProcesses().map(process -> new ProcessInfo(process.info()))
andrewfg marked this conversation as resolved.
Show resolved Hide resolved
.filter(info -> (info.command != null) || (info.commandLine != null))
andrewfg marked this conversation as resolved.
Show resolved Hide resolved
.collect(Collectors.toUnmodifiableSet());
} catch (SecurityException | UnsupportedOperationException unused) {
logger.info("Cannot obtain process list, suggesting add-ons based on running processes is not possible");
Expand Down