Fix the recursive group membership check #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a group to be a member of its direct parent and also its parent's ancestors without raising an error. Looping membership is still detected and prevented as before, thus Stack Overflow is still avoided. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/recursive-group-membership-found/135192/29 |
|
Thanks, fixes a warning in my logs I have been ignoring all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a group to be a member of its direct parent and also its parent's ancestors without raising an error.
So this scenario is now allowed:
Looping membership is still detected and prevented as before, thus Stack Overflow is still avoided.
So this scenario is still not allowed, as it was originally intended:
and also not allowed:
Hopefully the new error message is also easier to understand, although it will only be issued when a real membership loop occurred.
See https://community.openhab.org/t/recursive-group-membership-found/135192
#3748