Call, Contact, Image items: Don't create command descr from state descr #4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are not accepted If a state description is set on a contact item, currently a command description is automatically created as well. This is wrong as contact items do not accept commands (except refresh) and caused the UI to display a control for the default (list) widget for these contacts. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
Doesn't that apply to |
|
True, I can fix them too. One thing that however needs to be thought of, is that it then won't be possible to set a command description anymore. We could create a protected method |
…ription Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@J-N-K FYI I went ahead and implemented my proposal, easy to revert in case you don't like it. |
florian-h05
changed the title
florian-h05
changed the title
|
It would be nice if we could squeeze that one into the milestone as well 👍 |
kaikreuzer
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a state description is set on a contact item, currently a command description is automatically created as well.
This is wrong as contact items do not accept commands (except refresh) and caused the UI to display a control for the default (list) widget for these contacts.