Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST call to get orphan links #4115

Merged
merged 4 commits into from Mar 23, 2024
Merged

Conversation

seime
Copy link
Contributor

@seime seime commented Feb 27, 2024

Add a REST call to expose broken links, similar to openhab-cli orphan links.

MainUI user interface in a separate PR

Signed-off-by: Arne Seime <arne.seime@gmail.com>
Signed-off-by: Arne Seime <arne.seime@gmail.com>
@seime seime requested a review from J-N-K March 10, 2024 13:02
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Copy link
Member

J-N-K commented Mar 15, 2024

Did you see my PR to your repo? WDYT?

@seime
Copy link
Contributor Author

seime commented Mar 16, 2024

No, I didn't notice it, thanks for letting me know.

LGTM

@J-N-K
Copy link
Member

J-N-K commented Mar 23, 2024

@wborn @kaikreuzer Since I contribted code I feel it would be best if someone else could have a final look here.

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit bf8b131 into openhab:main Mar 23, 2024
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.2 milestone Mar 23, 2024
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Mar 23, 2024
@seime seime deleted the orphan_links_rest branch May 3, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants