Upgrade tool: Add upgrade task for script profile changes #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs openhab#4058. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
J-N-K
requested changes
Feb 28, 2024
tools/upgradetool/pom.xml
Outdated
| @@ -15,7 +15,7 @@ | |||
| <packaging>jar</packaging> | |||
|
|
|||
| <name>openHAB Core :: Tools :: Upgrade tool</name> | |||
| <description>A tool for upgrading openHAB from 3.4 to 4.0</description> | |||
| <description>A tool for upgrading openHAB from 3.4 to 4.x</description> | |||
There was a problem hiding this comment.
Suggested change
| <description>A tool for upgrading openHAB from 3.4 to 4.x</description> | |
| <description>A tool for upgrading openHAB</description> |
| */ | ||
| @NonNullByDefault | ||
| public class Upgrader { | ||
| public static final String ITEM_COPY_UNIT_TO_METADATA = "itemCopyUnitToMetadata"; | ||
| public static final String LINK_UPGRADE_JS_PROFILE = "linkUpgradeJsProfile"; | ||
| public static final String LINK_UPGRADE_SCRIPT_PROFILE = "linkUpgradeScriptProfile"; | ||
| private static final Set<String> SCRIPT_PROFILE_NAMES = Set.of("transform:NASHORNJS", "transform:JS", |
There was a problem hiding this comment.
Wouldn't it make more sense to use transform:.* and match a regex? Otherwise script profiles with JRule, JavaRule or other languages would not be transformed.
There was a problem hiding this comment.
Hmm, this should work as well 👍
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #4058.
/cc @jimtng @J-N-K