[sitemap] Extend chart periods to cover past and future #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes openhab/openhab-webui#2518 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
chart_period_future
branch
from
7ade1e1
to
fb5f7c1
Compare
|
I added unit tests, this is now ready for review. |
|
The change is fully backward compatible. |
andrewfg
reviewed
Apr 6, 2024
...ab.core.ui/src/test/java/org/openhab/core/ui/internal/chart/ChartServletPeriodParamTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
florian-h05
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Apr 12, 2024
Chart widget sitemap configuration has been extended with support for future periods in openhab/openhab-core#4172. This adds configuration in the UI. See #2518. Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes openhab/openhab-webui#2518
Signed-off-by: Laurent Garnier lg.hc@free.fr