Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add Java 21 compiling to J17 and native J21 #4186

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Apr 14, 2024

As we have implemented all changes that allow for Java 21 builds, I'd like to introduce it in the CI as well.
For full Java 21 support, we are still lacking a solution for changed serialization #4174, which currently prohibits changing the JDK version of an existing installation.

This does not affect the build and test, so I propose to add 2 new build targets to the CI in addition to the existing Java 17 build:

  • Java 21, generating Java 17 class files
  • profile-j21, i.e. Java 21, generating Java 21 class files

Any hints to improve naming of the targets or to simplify the workflow file are appreciated.

I have already tested this on my forked repo and rebased a few times to check if it works reliably.
https://github.com/holgerfriedrich/openhab-core/actions

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich requested a review from a team as a code owner April 14, 2024 20:58
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer added this to the 4.2 milestone Apr 21, 2024
@kaikreuzer kaikreuzer merged commit 10a20af into openhab:main Apr 21, 2024
5 checks passed
@holgerfriedrich holgerfriedrich deleted the pr-ci-java21 branch April 21, 2024 09:53
@holgerfriedrich
Copy link
Member Author

@kaikreuzer shall I configure the branch protection to require all 3 builds to succeed?
Currently only DCO and Build on Java 17 are mandatory....

@kaikreuzer
Copy link
Member

Yeah, might make sense!

@holgerfriedrich
Copy link
Member Author

holgerfriedrich commented Apr 21, 2024

@kaikreuzer I will wait a few days until the recent PRs got merged or rebased on current main branch that contains the Java 21 builds.
Otherwise all PR builds will be marked with a yellow dot since not all mandatory builds are completed.
We could merge of course, ignoring the missing checks.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-2-milestone-discussion/154316/108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants