-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sitemap] Buttongrid as container for new Button elements #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
force-pushed
the
sitemap_button_element
branch
4 times, most recently
from
May 9, 2024 11:18
7a3552c
to
034d909
Compare
The proposed syntax for the
Explanations of the parameters:
Such |
lolodomo
force-pushed
the
sitemap_button_element
branch
3 times, most recently
from
May 10, 2024 09:21
44db537
to
1aed720
Compare
Related to openhab#4173 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
sitemap_button_element
branch
from
May 10, 2024 10:01
1aed720
to
b4d05fc
Compare
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
May 10, 2024
Related to openhab/openhab-core#4173 Depends on openhab/openhab-core#4223 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
May 10, 2024
Related to openhab/openhab-core#4173 Depends on openhab/openhab-core#4223 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
May 11, 2024
Related to openhab/openhab-core#4173 Depends on openhab/openhab-core#4223 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
May 11, 2024
Related to openhab/openhab-core#4173 Depends on openhab/openhab-core#4223 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
approved these changes
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
kaikreuzer
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
May 18, 2024
Related to openhab/openhab-core#4173 Depends on openhab/openhab-core#4223 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-core
that referenced
this pull request
May 21, 2024
Problem introduced by openhab#4223 checkFramesInWidgetList for LinkableWidget was triggering an error when the Buttongrid element has no parameter set. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
ccutrer
pushed a commit
to openhab/openhab-jruby
that referenced
this pull request
May 21, 2024
This is to adapt to the change in core: openhab/openhab-core#4223 A separate PR will be created to add support for the new `Button` widget Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
This was referenced May 21, 2024
kaikreuzer
pushed a commit
that referenced
this pull request
May 26, 2024
Problem introduced by #4223 checkFramesInWidgetList for LinkableWidget was triggering an error when the Buttongrid element has no parameter set. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4173
Signed-off-by: Laurent Garnier lg.hc@free.fr