Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to JAX-RS Whiteboard #1108

Merged
merged 6 commits into from May 15, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented May 4, 2020

When de.maggu2810.thirdparty.modified.org.reflections is used as runtime dependency, the Swagger bundles resolve properly because it has an optional dependency on com.google.common.base .
So now /rest/swagger.json is also generated and the REST Docs UI will properly work. 馃檪

Fixes #945
Fixes #1045

Depends on openhab/openhab-core#1443

@wborn wborn added the work in progress A PR that is not yet ready to be merged label May 4, 2020
When de.maggu2810.thirdparty.modified.org.reflections is used as runtime dependency, the Swagger bundles resolve properly because it has an optional dependency on com.google.common.base .
So now /rest/swagger.json is also generated and the REST Docs UI will properly work.

Fixes openhab#1045

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the jax-rs-whiteboard-migration branch from 69d5fa7 to 3afd113 Compare May 4, 2020 08:34
wborn added 2 commits May 4, 2020 16:13
Signed-off-by: Wouter Born <github@maindrain.net>
This version adds the jul-to-slf4j bridge (FELIX-6027).
JUL is used by CXF and using the bridge we can use logback to reduce the verbosity of the info logging whenever org.apache.cxf.endpoint.ServerImpl creates endpoints.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the jax-rs-whiteboard-migration branch from f4a0de5 to d15f31b Compare May 4, 2020 20:16
* Removes the hated default web application (ARIES-1931)
* Improves performance
* Uses CXF 3.2.12

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn removed the work in progress A PR that is not yet ready to be merged label May 5, 2020
@wborn wborn changed the title [WIP] Migrate to JAX-RS Whiteboard Migrate to JAX-RS Whiteboard May 5, 2020
@wborn wborn marked this pull request as ready for review May 5, 2020 20:16
@wborn wborn requested a review from a team May 5, 2020 20:16
@wborn
Copy link
Member Author

wborn commented May 5, 2020

The code is ready for review and it can be merged as soon as Jersey is removed as dependency from the remaining add-ons.

@wborn wborn added the awaiting other PR Depends on another PR label May 5, 2020
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the jax-rs-whiteboard-migration branch from 153dda6 to 9e06b4d Compare May 5, 2020 20:27
@wborn wborn removed the awaiting other PR Depends on another PR label May 8, 2020
Signed-off-by: Wouter Born <github@maindrain.net>
@cweitkamp cweitkamp added rebuild Triggers a new PR build and removed rebuild Triggers a new PR build labels May 14, 2020
@kaikreuzer kaikreuzer added rebuild Triggers a new PR build and removed rebuild Triggers a new PR build labels May 15, 2020
@wborn
Copy link
Member Author

wborn commented May 15, 2020

See openhab/org.openhab.binding.zigbee#578 regarding the build failures.

@kaikreuzer
Copy link
Member

Yeah, I was just after that :-)
The rest went well, so it does not stop me from merging!

@kaikreuzer kaikreuzer merged commit 5bdcaf2 into openhab:master May 15, 2020
@wborn wborn deleted the jax-rs-whiteboard-migration branch May 15, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants