Merge addon info of all repos into one addons.xml file #1626
Conversation
Extracts the ZigBee and Z-Wave addon.xml files and merges them into the addons.xml file using Groovy. Signed-off-by: Wouter Born <github@maindrain.net>
| /** | ||
| * Copyright (c) 2010-2024 Contributors to the openHAB project | ||
| * | ||
| * See the NOTICE file(s) distributed with this work for additional | ||
| * information. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Eclipse Public License 2.0 which is available at | ||
| * http://www.eclipse.org/legal/epl-2.0 | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 | ||
| */ |
There was a problem hiding this comment.
Is this license header needed, and if so, is there a configuration in this repository for automatically updating copyright year in license headers?
There was a problem hiding this comment.
I added it because we also have it on our other Groovy file.
There is no license-maven-plugin config currently but we can add it before 2025 when the header survives the pull request.
|
Just tried it out, addons.xml now contains zwave an zway. It is in the distro zip and accepted by the addon finders. 👍 |
@wborn Bad news. Unfortunately there seem to be issues, at least when building on Windows..... Seems I have not seen this in the first tryout because I touched the new addons.xml and VS Code fixed it when saving.... We seem to have mixed line endings:
The XML parser fails. (When I fix this, I seen to break the encoding in the description of nobohub binding, so I removed the UTF8 characters). |
Signed-off-by: Wouter Born <github@maindrain.net>
|
Does it work better with the new commit? |
Signed-off-by: Wouter Born <github@maindrain.net>
|
It seems to always print the XML using Unix line endings so I've updated the script for that. |
|
Almost fine, but not yet. Still the parser is unable to handle it. Hope this is not caused by some weird stuff on my machine. Freshly generated distro zip: fail. Opening Not working: After saving: |
Signed-off-by: Wouter Born <github@maindrain.net>
|
With the new commit it seems to work better on my Windows VM. |
|
Does not work for me - same output as before. This character is correct in ./distributions/openhab/target/addon-xml/addons.xml, but broken in ./distributions/openhab/target/assembly/runtime/etc/addons.xml. |
Signed-off-by: Wouter Born <github@maindrain.net>
|
How does this BufferedWriter work for you? 🙂 |
|
Yeah, that did the trick! 🚀 👍 |
|
Great! 😅 If it works on Linux and Windows I cannot imagine it will not work macOS. 😉 |
J-N-K
added
PR pending
Extracts the ZigBee and Z-Wave addon.xml files and merges them into the addons.xml file using Groovy.