Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Maven tooling #1627

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Improve Maven tooling #1627

merged 2 commits into from
Jan 10, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 5, 2024

  • Add license, sortpom and spotless Maven plugin configurations similar to other repos
  • Add license files
  • Sort POMs and apply Spotless

Depends on #1626

@wborn wborn added awaiting other PR Depends on another PR infrastructure labels Jan 5, 2024
@wborn wborn requested a review from a team as a code owner January 5, 2024 12:07
@wborn wborn mentioned this pull request Jan 5, 2024
Merged
@J-N-K
Copy link
Member

J-N-K commented Jan 5, 2024

Can you resolve the merge conflict? Thanks!

@wborn
Improve Maven tooling
e30df09 
* Add license, sortpom and spotless Maven plugin configurations similar to other repos
* Add license files

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Sort POMs and apply Spotless
dea6e11 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn removed the awaiting other PR Depends on another PR label Jan 5, 2024
@wborn wborn requested a review from J-N-K January 9, 2024 19:07
J-N-K
J-N-K approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J-N-K J-N-K added this to the 4.2 milestone Jan 10, 2024
@J-N-K J-N-K merged commit 1c4dc27 into openhab:main Jan 10, 2024
3 checks passed
@wborn wborn deleted the improve-maven-tooling branch January 10, 2024 18:20
wborn added a commit to wborn/openhab-docker that referenced this pull request Jan 14, 2024
@wborn
Fix SNAPSHOT version logic
63b109b 
The POMs got reformatted with openhab/openhab-distro#1627.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this pull request Jan 14, 2024
Merged
wborn added a commit to openhab/openhab-docker that referenced this pull request Jan 14, 2024
@wborn
Fix SNAPSHOT version logic (#437)
6b548ff 
The POMs got reformatted with openhab/openhab-distro#1627.

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wborn @J-N-K