Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tab containers #1023

Merged
merged 7 commits into from
Aug 9, 2019
Merged

Add support for tab containers #1023

merged 7 commits into from
Aug 9, 2019

Conversation

ghys
Copy link
Member

@ghys ghys commented Aug 3, 2019

Uses https://github.com/pskordilakis/vuepress-tabs.

Related to openhab/website#183.

Update dependencies.

Signed-off-by: Yannick Schaus github@schaus.net

Uses https://github.com/pskordilakis/vuepress-tabs.

Related to openhab/website#183.

Update dependencies.

Signed-off-by: Yannick Schaus <github@schaus.net>
@netlify
Copy link

netlify bot commented Aug 3, 2019

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built with commit 54aec0d

https://deploy-preview-1023--openhab-docs-preview.netlify.com

Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys
Copy link
Member Author

ghys commented Aug 3, 2019

@openhab-5iver @Confectrician could you have a look at
https://deploy-preview-1023--openhab-docs-preview.netlify.com/docs/configuration/jsr223.html#just-testing-the-tabs
and check whether or not it fits your requirements for openhab/website#183?
One functionality which doesn't appear possible is to switch all tabs on the same page at once when you click one...
If you approve this addition I will remove the test paragraph before merging.

@5iver
Copy link
Contributor

5iver commented Aug 3, 2019

I won't be able to look from my computer for a couple hours, but this is from Firefox on mobile...

Screenshot_20190803-084941

... not very tabby, but SO much better than nothing... thank you! Sphinx uses Pygments for code highlighting, so I'd setup a style that mimics VS Code.

@ghys
Copy link
Member Author

ghys commented Aug 3, 2019

Heh, indeed, on desktops it looks better. Since there'll be room in most cases to display the tabs inline even on phones, it makes sense to cancel the responsive stuff; could probably be done by tweaking or overriding the provided styles.

@openhab openhab deleted a comment from netlify bot Aug 3, 2019
@5iver
Copy link
Contributor

5iver commented Aug 3, 2019

Finally got to look at this (Firefox desktop)... and this is fantastic! The outer border is a little lighter (IMO too light), but it looks identical to what you get with Sphinx. Can it do nested tabs? Please merge!

I realize this is really a separate topic, but what is being used for the code highlighting? It would be nice if it looked more like VS Code. Here's the Pygment style I'd mentioned... it's not perfect, but might help with the colors.

@ghys
Copy link
Member Author

ghys commented Aug 4, 2019

what is being used for the code highlighting

https://highlightjs.org/static/demo/

I can't seem to find the style VuePress uses by default, but there seem to be a VS style as well.

Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys
Copy link
Member Author

ghys commented Aug 4, 2019

Ok should be good for merging. (minus the test paragraph)
I'll have to add an equivalent PR to the website side.

@ghys ghys changed the title [WIP] Add support for tab containers Add support for tab containers Aug 4, 2019
@ghys ghys requested a review from Confectrician August 4, 2019 20:00
@5iver
Copy link
Contributor

5iver commented Aug 4, 2019

Looks good on mobile now too!

@Confectrician
Copy link
Contributor

I had a quick look on desktop and its fantastic. 🙂

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys
Copy link
Member Author

ghys commented Aug 9, 2019

Ok I have nothing more to add, let's merge this then.
You can work on PRs here and get the preview with tabs, but don't merge them until the website is done. :)

@ghys ghys merged commit 85c3431 into master Aug 9, 2019
@ghys ghys deleted the tabs branch August 9, 2019 16:39
ghys added a commit to ghys/openhab-website that referenced this pull request Aug 9, 2019
Related to openhab/openhab-docs#1023

Uses https://github.com/pskordilakis/vuepress-tabs.

Closes openhab#183.

Update dependencies.

Signed-off-by: Yannick Schaus <github@schaus.net>
ghys added a commit to ghys/openhab-website that referenced this pull request Aug 9, 2019
Related to openhab/openhab-docs#1023

Uses https://github.com/pskordilakis/vuepress-tabs.

Closes openhab#183.

Update dependencies.

Signed-off-by: Yannick Schaus <github@schaus.net>
ghys added a commit to openhab/website that referenced this pull request Sep 8, 2019
Related to openhab/openhab-docs#1023
Uses https://github.com/pskordilakis/vuepress-tabs.
Closes #183.

+ Update dependencies

Signed-off-by: Yannick Schaus <github@schaus.net>
@Confectrician Confectrician added this to the 2.x.x milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants