-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tab containers #1023
Conversation
Uses https://github.com/pskordilakis/vuepress-tabs. Related to openhab/website#183. Update dependencies. Signed-off-by: Yannick Schaus <github@schaus.net>
Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits). Built with commit 54aec0d https://deploy-preview-1023--openhab-docs-preview.netlify.com |
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
@openhab-5iver @Confectrician could you have a look at |
I won't be able to look from my computer for a couple hours, but this is from Firefox on mobile... ... not very tabby, but SO much better than nothing... thank you! Sphinx uses Pygments for code highlighting, so I'd setup a style that mimics VS Code. |
Heh, indeed, on desktops it looks better. Since there'll be room in most cases to display the tabs inline even on phones, it makes sense to cancel the responsive stuff; could probably be done by tweaking or overriding the provided styles. |
Finally got to look at this (Firefox desktop)... and this is fantastic! The outer border is a little lighter (IMO too light), but it looks identical to what you get with Sphinx. Can it do nested tabs? Please merge! I realize this is really a separate topic, but what is being used for the code highlighting? It would be nice if it looked more like VS Code. Here's the Pygment style I'd mentioned... it's not perfect, but might help with the colors. |
https://highlightjs.org/static/demo/ I can't seem to find the style VuePress uses by default, but there seem to be a VS style as well. |
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Ok should be good for merging. (minus the test paragraph) |
Looks good on mobile now too! |
I had a quick look on desktop and its fantastic. 🙂 |
Signed-off-by: Yannick Schaus <github@schaus.net>
Ok I have nothing more to add, let's merge this then. |
Related to openhab/openhab-docs#1023 Uses https://github.com/pskordilakis/vuepress-tabs. Closes openhab#183. Update dependencies. Signed-off-by: Yannick Schaus <github@schaus.net>
Related to openhab/openhab-docs#1023 Uses https://github.com/pskordilakis/vuepress-tabs. Closes openhab#183. Update dependencies. Signed-off-by: Yannick Schaus <github@schaus.net>
Related to openhab/openhab-docs#1023 Uses https://github.com/pskordilakis/vuepress-tabs. Closes #183. + Update dependencies Signed-off-by: Yannick Schaus <github@schaus.net>
Uses https://github.com/pskordilakis/vuepress-tabs.
Related to openhab/website#183.
Update dependencies.
Signed-off-by: Yannick Schaus github@schaus.net