Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab-Style possible? #183

Closed
Confectrician opened this issue May 1, 2019 · 6 comments · Fixed by #200
Closed

Tab-Style possible? #183

Confectrician opened this issue May 1, 2019 · 6 comments · Fixed by #200

Comments

@Confectrician
Copy link
Contributor

Hi,

Is it possible to add tabs in the standard theme?
I would love to have to ability to save rule examples in more than one rule language we support.

This was my idea of how it could look:
rulesTabs

Would be very nice, if this would work in theory.
If yes, we would have to find a way to reflect this in our markdown files, but i will start thinking about it when i have an answer here.
Doesn't make sense to do so, when it isn't possible with vuepress.

@ghys
Copy link
Member

ghys commented May 1, 2019

That's probably possible with a Vue component at first sight, not entirely sure though.

@Confectrician
Copy link
Contributor Author

I am self learning Vue out of interest currently, but did not yet investigate time into components.
I will have an eye open when i am at that point. :)

@5iver
Copy link

5iver commented May 1, 2019

ECMAScript would be more accurate. I took this comment to mean "Use ECMAScript" and is how I was planning to setup the repo. Or did I get it wrong?

BTW, this is how the script types are displayed in the UI dropdown. Javascript was not an option.
openhab/openhab-core#635 (comment).

image

For the same reasoning, Jython should be Python.

@Confectrician
Copy link
Contributor Author

Thanks for the feedback @openhab-5iver.
But as already stadet above this justa showcase example and we can start talking about the "how", when we have found a way to do this generally.

@5iver
Copy link

5iver commented May 2, 2019

OK! BTW, this looks great and will be very useful. I can also imagine Beginner/Advanced/Expert tabs.

@ghys
Copy link
Member

ghys commented Aug 3, 2019

Just had another look at this and stumbled across https://github.com/pskordilakis/vuepress-tabs - this looks like exactly what we want. I can have a look at including it for a quick-win solution.
One caveat is the underlying component to render the tabs is not maintained anymore. It will probably work well enough though until major framework upgrades are performed on the site. It looks like this.

If we ever decide to upgrade to VuePress 1.0 from 0.9 - probably a non-trivial change so planned but no commitment yet - the good news is, there's a equivalent plugin.

ghys added a commit to openhab/openhab-docs that referenced this issue Aug 3, 2019
Uses https://github.com/pskordilakis/vuepress-tabs.

Related to openhab/website#183.

Update dependencies.

Signed-off-by: Yannick Schaus <github@schaus.net>
ghys added a commit to ghys/openhab-website that referenced this issue Aug 9, 2019
Related to openhab/openhab-docs#1023

Uses https://github.com/pskordilakis/vuepress-tabs.

Closes openhab#183.

Update dependencies.

Signed-off-by: Yannick Schaus <github@schaus.net>
ghys added a commit to ghys/openhab-website that referenced this issue Aug 9, 2019
Related to openhab/openhab-docs#1023

Uses https://github.com/pskordilakis/vuepress-tabs.

Closes openhab#183.

Update dependencies.

Signed-off-by: Yannick Schaus <github@schaus.net>
ghys added a commit that referenced this issue Sep 8, 2019
Related to openhab/openhab-docs#1023
Uses https://github.com/pskordilakis/vuepress-tabs.
Closes #183.

+ Update dependencies

Signed-off-by: Yannick Schaus <github@schaus.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants