-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[luftdateninfo][sensorcommunity] Rename binding #2082
Conversation
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks! I think the text needs to be removed or changed to sensor.community. See their website. But I don't know about copyright, fair use, etc.... |
I checked the licenses here: https://sensor.community/de/ (see "legal") |
@holgerfriedrich Any news on this regarding my comment? |
No progress, working on a different topic. Maybe the quick solution would be to delete the obsolete file. I can close this PR. |
Binding was renamed to SensorCommunity, logo no longer matches. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
87e9b42
to
4e1824f
Compare
@stefan-hoehn I just pushed the delete to remove the icon for luftdateninfo, which is anyway obsolete after renaming of the binding. |
Closing PR upon request, don't hesitate a new one later for the renamed binding. |
@stefan-hoehn sorry I think you got me wrong. This PR now just deletes the obsolete file, it can be merged. Binding is already renamed. The open point is the new logo - this can be a new PR. I just don't want to mess with any legal topics. I don't know about fair use or what is actually allowed to take and upload. |
Merging now to clean the outdated logo. :) |
Rename addon icon due to renaming of the binding. openhab/openhab-addons#15012
However, the icon still needs to be reworked. The old name is part of the logo.
Maybe the project can assist and provide a new logo, e.g. based on https://sensor.community/favicon.png
@pjgueno