Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luftdateninfo][sensorcommunity] Rename binding #2082

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

holgerfriedrich
Copy link
Member

Rename addon icon due to renaming of the binding. openhab/openhab-addons#15012

However, the icon still needs to be reworked. The old name is part of the logo.

Maybe the project can assist and provide a new logo, e.g. based on https://sensor.community/favicon.png
@pjgueno

@netlify
Copy link

netlify bot commented May 21, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 4e1824f
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/64a04072698fcd0008cdc672
😎 Deploy Preview https://deploy-preview-2082--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefan-hoehn
Copy link
Contributor

Like so?

image

or so

image

@holgerfriedrich
Copy link
Member Author

Thanks! I think the text needs to be removed or changed to sensor.community. See their website.

But I don't know about copyright, fair use, etc....

@stefan-hoehn
Copy link
Contributor

I checked the licenses here: https://sensor.community/de/ (see "legal")
I personally see no issues for using the logo but you may ask in the forum. Then I would recommend to not only change the filename but the logo itself as well. You can find the official logos here: https://sensor.community/de/presskit/

Confectrician

This comment was marked as outdated.

@stefan-hoehn
Copy link
Contributor

@holgerfriedrich Any news on this regarding my comment?

@holgerfriedrich
Copy link
Member Author

No progress, working on a different topic.
Doc export is anyway blocked by #2085.

Maybe the quick solution would be to delete the obsolete file. I can close this PR.

Binding was renamed to SensorCommunity, logo no longer matches.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich
Copy link
Member Author

@stefan-hoehn I just pushed the delete to remove the icon for luftdateninfo, which is anyway obsolete after renaming of the binding.
Please feel free to close my PR in case you want to upload a new logo in a combined PR.

@stefan-hoehn
Copy link
Contributor

Closing PR upon request, don't hesitate a new one later for the renamed binding.

@holgerfriedrich
Copy link
Member Author

@stefan-hoehn sorry I think you got me wrong. This PR now just deletes the obsolete file, it can be merged. Binding is already renamed.

The open point is the new logo - this can be a new PR. I just don't want to mess with any legal topics. I don't know about fair use or what is actually allowed to take and upload.

@Confectrician Confectrician reopened this Jul 1, 2023
@Confectrician
Copy link
Contributor

Merging now to clean the outdated logo. :)

@Confectrician Confectrician merged commit d73012d into openhab:main Jul 1, 2023
7 checks passed
@holgerfriedrich holgerfriedrich deleted the pr-sensorcommunity branch July 1, 2023 16:03
@Confectrician Confectrician added this to the 4.0 milestone Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants