New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirects for old OH2 binding links #296
Conversation
Requires installation of [jekyll-redirect-from](https://github.com/jekyll/jekyll-redirect-from) plugin. Fixes openhab#295 Signed-off-by: John Cocula <john@cocula.com>
Signed-off-by: John Cocula <john@cocula.com>
Sadly not possible as we are on GitHub pages. |
Signed-off-by: John Cocula <john@cocula.com>
OK, I see. The readme for the plugin says to add it to the whitelist, but it doesn't say that the plugin isn't available on GitHub pages. Oh well! |
...this page says it's possible? |
Is there any chance to keep the "old" links as the main/official links in place? If possible in any way, e.g. through the build process, this should imho be done. They are much more logical as they follow the same scheme that is used in distro extension service to identify add-ons. |
To have the add-on doc URLs track the feature names where "1" is appended to 1.x binding IDs, requires that the build process abandons the maven-resources-plugin for copying the source files. Some Groovy code might have to do the job instead. ...or a further rename, I will take a look. |
To keep links to binding docs as they were and to track the feature name of bindings. The bindings/oh1 and bindings/oh2 subdirectories are now gone. This PR supercedes openhab#296. Should persistence and actions be moved up a level from their current “oh1” directory, since they don’t use the “1” appended to the feature name? If yes, what happens when new features for persistence or actions are added later in OH2? Signed-off-by: John Cocula <john@cocula.com>
Superseded by #297. |
* Binding docs track feature naming convention To keep links to binding docs as they were and to track the feature name of bindings. The bindings/oh1 and bindings/oh2 subdirectories are now gone. * Assuming the existing convention of `openhab-${type}-${id}` feature name will always mean the doc goes to `addons/${type}s/${id}`, this commit reflects this for actions, bindings and persistence service names. This PR supercedes #296. Signed-off-by: John Cocula <john@cocula.com>
Fixes #295.
Requires installation of jekyll-redirect-from plugin.
Signed-off-by: John Cocula john@cocula.com