Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginner Tutorial: Overview & Chapter Installing Extension #70

Merged
merged 4 commits into from
Sep 18, 2016
Merged

Beginner Tutorial: Overview & Chapter Installing Extension #70

merged 4 commits into from
Sep 18, 2016

Conversation

joergkling
Copy link
Contributor

First version of chapters:

1.2.1 Overview
1.2.3 Installing an Extension

Issue: #61

Signed-off-by: Joerg Kling joerg.kling@gmail.com

Signed-off-by: Joerg Kling <joerg.kling@gmail.com>
Signed-off-by: Joerg Kling <joerg.kling@gmail.com>
<li><a href="{{docu}}/installing.html">Installing an Extension</a></li>
<li><a href="{{docu}}/configuring.html">Configuring Functionality</a></li>
<li><a href="{{docu}}/definingui.html">Defining User Interface</a></li>
<li><a href="{{docu}}/logs.html">Looking to the Logs</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the document names are a good match? I feel like nouns are more common for html names!? Could be wrong :)
"installextension.html" or "uisetup.html"?

@ThomDietrich
Copy link
Member

On a side note: there are multiple reasons why it is always a good idea to create a pull request based on a new branch. You committed your changes directly to joergkling/openhab-docs:gh-pages instead of for example joergkling/openhab-docs:tutorial


## Prerequisites

* Installed [openHab Designer](http://docs.openhab.org/installation/designer.html) and read/write access to the **CONF** folder of your openHAB server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Eclipse SmartHome Designer"

CONF is not in sync with the rest of the documentation. The conf folder my be called different. For example, in a repository based installation on linux, your conf folder is /etc/openhab2. That's why it will be better to write "to your openHAB configuration folder"

@ThomDietrich
Copy link
Member

Hey @joergkling, I left you a few comments. I hope everything can be settled easily ;)

@ThomDietrich
Copy link
Member

Do you know when you'll have the time? Would be great to merge soon ;)

Signed-off-by: Joerg Kling <joerg.kling@gmail.com>
Signed-off-by: Joerg Kling <joerg.kling@gmail.com>
@ThomDietrich
Copy link
Member

Hey @joergkling, is this finished and ready to merge?

@ThomDietrich ThomDietrich changed the base branch from gh-pages to tutorial-update September 18, 2016 12:25
@ThomDietrich ThomDietrich merged commit 1cf9e16 into openhab:tutorial-update Sep 18, 2016
@Confectrician Confectrician added this to the 2.0 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants