Add temperatureRange to TemperatureSensor #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michikrug, is it possible to add the optional |
Yes, but it would not serve any purpose with a query only device. And so far we do not have other devices for that trait. |
Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
michikrug
force-pushed
the
temperaturerange
branch
from
0c6e352
to
ec7723b
Compare
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #426, the
TemperatureControltrait requires thetemperatureRangeattribute.This was missing so far.
This PR adds this attribute to the
TemperatureSensordevice type.It also introduces a default range of -100°C to 100°C as a fallback, when no range is provided.
Fixes #426
TODO: