Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main UI Inbox Show Ignored checkox cannot be checked #2457

Closed
andrewfg opened this issue Mar 5, 2024 · 5 comments · Fixed by #2472
Closed

Main UI Inbox Show Ignored checkox cannot be checked #2457

andrewfg opened this issue Mar 5, 2024 · 5 comments · Fixed by #2472
Labels
bug Something isn't working main ui Main UI question Further information is requested

Comments

@andrewfg
Copy link

andrewfg commented Mar 5, 2024 •
edited

OH 4.2M1 plus Chrome browser

The Main UI Inbox Show Ignored checkbox cannot be checked or unchecked when Alphabetical sort is selected. Yet by contrast it can be checked or unchecked when By Binding sort is selected.
@andrewfg andrewfg added bug Something isn't working main ui Main UI labels Mar 5, 2024
@florian-h05
Copy link
Contributor

On the latest snapshot with Chromium 122.0.6261.111 it is working fine.
I can’t reproduce the issue.

@florian-h05 florian-h05 added the question Further information is requested label Mar 12, 2024
@andrewfg
Copy link
Author

@florian-h05 see video below..

Screen_Recording_20240312_225516_Chrome.mp4

@florian-h05
Copy link
Contributor

Hmm, the problem is the list index (those tiny orange letters on the right border of the screen), their element collides with the checkbox. (BTW, the label is still clickable).

I don't have a real fix, but to work around that issue, I would switch the order of the label and the checkbox, even though it looks a bit awkward. WDYT?

@andrewfg
Copy link
Author

to work around that issue, I would switch the order of the label and the checkbox, even though it looks a bit awkward. WDYT?

Sounds OK to me. I originally noticed the issue on the Inbox screen, but based on your explanation I think it might also apply to other screens as well. ??

@florian-h05
Copy link
Contributor

I have checked all other screens which use such a list index, they don't have elements affected by the index, so it's just the Thing inbox.

florian-h05 added a commit to florian-h05/openhab-webui that referenced this issue Mar 13, 2024
@florian-h05
Thing inbox: Fix "show ignored" checkbox not checkable on small screens
c7fda0b 
Fixes openhab#2457.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 mentioned this issue Mar 13, 2024
Merged
florian-h05 added a commit that referenced this issue Mar 13, 2024
@florian-h05
Thing inbox: Fix "show ignored" checkbox not checkable on small scree…
a1eca7d 
…ns (#2472)

Fixes #2457.

The list index collided with the "show ignored" checkbox and caused it
to not be checkable on smaller screens (mobile phones).
As I have found no real fix for this issue (setting z-indizes does not
work due to the structure of the page), I created this workaround to
switch the checkbox and the label on smaller screens.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Thing inbox: Fix "show ignored" checkbox not checkable on small screens florian-h05/openhab-webui
2 participants
@andrewfg @florian-h05