Thing inbox: Fix "show ignored" checkbox not checkable on small screens #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#2457. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Job #1795: Bundle Size — 11.13MiB (~+0.01%).Warning Bundle contains 19 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1795 report View florian-h05:thing-inbox-show-all branch activity View project dashboard |
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Mar 30, 2024
Follow-up for openhab#2472. Improve the condition to only show the reversed order where really required. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2457.
The list index collided with the "show ignored" checkbox and caused it to not be checkable on smaller screens (mobile phones).
As I have found no real fix for this issue (setting z-indizes does not work due to the structure of the page), I created this workaround to switch the checkbox and the label on smaller screens.