Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent modified files with Maven builds #1152

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

wborn
Copy link
Member

@wborn wborn commented Aug 31, 2021

#1113 only partially solved #241.

It might be better to run npm ci by default for more reproducible builds and to prevent changes to package-lock.json.

Related to openhab#241

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested review from ghys and a team as code owners August 31, 2021 16:40
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 738c399 into openhab:main Sep 18, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Sep 18, 2021
kaikreuzer pushed a commit that referenced this pull request Dec 12, 2021
Related to #241

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn deleted the prevent-modified-files branch May 26, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants