Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BasicUI] Use forceAsItem-option from sitemaps #1256

Merged
merged 1 commit into from
Apr 19, 2022
Merged

[BasicUI] Use forceAsItem-option from sitemaps #1256

merged 1 commit into from
Apr 19, 2022

Conversation

Flole998
Copy link
Member

Part of implementing openhab/openhab-core#2185

Depends-on: openhab/openhab-core#2657

@Flole998
Use forceAsItem-option from sitemaps
6705e78 
Depends-on: openhab/openhab-core#2657

Signed-off-by: Flole <flole@flole.de>
@Flole998 Flole998 requested a review from a team as a code owner December 30, 2021 23:46
@lolodomo lolodomo added the basic ui Basic UI label Feb 7, 2022
@Flole998
Copy link
Member Author

Flole998 commented Apr 5, 2022

@lolodomo The PR this depends on has been merged. So this can be rebuilt and then reviewed and merged now.

@lolodomo lolodomo added rebuild trigger a new Jenkins job and removed rebuild trigger a new Jenkins job labels Apr 5, 2022
@Flole998
Copy link
Member Author

Flole998 commented Apr 5, 2022

Sorry, seems like I was too fast there. OH-core wasn't rebuild yet apparently, I guess we need to check back tomorrow.

@lolodomo lolodomo added rebuild trigger a new Jenkins job and removed rebuild trigger a new Jenkins job labels Apr 19, 2022
lolodomo
lolodomo approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented Apr 19, 2022 •
edited
Loading

Build is failing... in HABot.
BasicUI part is apparently ok.

@lolodomo
Copy link
Contributor

@ghys : is there any risk to merge?

@lolodomo lolodomo changed the title Use forceAsItem-option from sitemaps [BasicUI]Use forceAsItem-option from sitemaps Apr 19, 2022
@lolodomo lolodomo changed the title [BasicUI]Use forceAsItem-option from sitemaps [BasicUI] Use forceAsItem-option from sitemaps Apr 19, 2022
@ghys
Copy link
Member

ghys commented Apr 19, 2022 •
edited
Loading 

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project org.openhab.ui.habot: Compilation failure
[ERROR] /home/jenkins/jenkins-agent1/workspace/PR-openHAB-WebUI/bundles/org.openhab.ui.habot/src/main/java/org/openhab/ui/habot/nlp/internal/OpenNLPInterpreter.java:[103,20] Null type mismatch: required 'java.lang.@NonNull String' but the provided value is null

I guess not, it seems unrelated. The PR was probably opened when there was an inconsistency in null checks between core and the implementations here. AFAIR it was finally fixed in #1318.

@ghys ghys merged commit 76c4dc9 into openhab:main Apr 19, 2022
@ghys ghys added the enhancement New feature or request label Apr 19, 2022
@ghys ghys added this to the 3.3 milestone Apr 19, 2022
@Flole998 Flole998 mentioned this pull request Apr 19, 2022
Closed
@timbms timbms mentioned this pull request Sep 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
basic ui Basic UI enhancement New feature or request
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Flole998 @lolodomo @ghys