Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event Terns #1292

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Add event Terns #1292

merged 2 commits into from
Jan 31, 2022

Conversation

Cossey
Copy link
Contributor

@Cossey Cossey commented Jan 31, 2022

Added event terns for the Triggers for both nashorn and openhab-js.
Add groupNames to Item (openhab/openhab-js#86)

Signed-off-by: Stewart Cossey stewart.cossey@gmail.com

Added event terns for the Trigger Types for both nashorn and openhab-js.
Add groupNames to Item (openhab/openhab-js#86)

Signed-off-by: Stewart Cossey <stewart.cossey@gmail.com>
@Cossey Cossey requested a review from a team as a code owner January 31, 2022 03:05
@relativeci
Copy link

relativeci bot commented Jan 31, 2022

Job #342: Bundle Size — 10.68MB (~+0.01%).

e66e082 vs 2cef790

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 7.06% 7.04%
Changed assets by type (1/7)
            Current     Baseline
JS 8.63MB (~+0.01%) 8.63MB

View Job #342 report on app.relative-ci.com

@ghys
Copy link
Member

ghys commented Jan 31, 2022

Excellent! While we're at it, would you kindly add getItems() to ItemsNamespace (openhab/openhab-js#70) as well, in this PR or a separate one, as you wish?

Signed-off-by: Stewart Cossey <stewart.cossey@gmail.com>
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghys ghys merged commit 6e06022 into openhab:main Jan 31, 2022
@ghys ghys added enhancement New feature or request main ui Main UI labels Jan 31, 2022
@ghys ghys added this to the 3.3 milestone Jan 31, 2022
@Cossey Cossey deleted the EventTerns branch February 1, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants