Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Thing configuration: Mask passwords in configuration read from files #1342

Merged
merged 1 commit into from
Apr 5, 2022
Merged

UI: Thing configuration: Mask passwords in configuration read from files #1342

merged 1 commit into from
Apr 5, 2022

Conversation

holgerfriedrich
Copy link
Member

For things configured via configuration files, the UI now masks passwords
by default. The behavior is now similar to things created in
the UI: passwords are only displayed after a click on the icon.

Signed-off-by: Holger Friedrich mail@holger-friedrich.de

@holgerfriedrich holgerfriedrich requested a review from a team as a code owner March 14, 2022 00:25
@relativeci
Copy link

relativeci bot commented Mar 14, 2022 •
edited
Loading

Job #379: Bundle Size — 10.7MB (+0.54%).

6372177 vs 314cc34

Changed metrics (4/10)
Metric Current Baseline
Initial JS 1.67MB(-0.02%) 1.67MB
Cache Invalidation 21.28% 18.13%
Assets 240(+0.42%) 239
Modules 1509(-0.07%) 1510
Changed assets by type (4/7)
            Current     Baseline
HTML 1.19KB (-21.16%) 1.5KB
IMG 140.74KB (+65.14%) 85.23KB
JS 8.64MB (+0.04%) 8.64MB
Other 846B (-1.4%) 858B

View Job #379 report on app.relative-ci.com

@ghys
Copy link
Member

ghys commented Apr 5, 2022

Thanks & sorry for the delay.
Could you sort out the check warnings shown in the "Files changed" tab please?

@holgerfriedrich
UI: Thing configuration: Mask passwords in configuration read from files
c611992 
For things configured via configuration files, the UI now masks passwords
by default. The behavior is now similar to things created in
the UI: passwords are only displayed after a click on the icon.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich force-pushed the pr-ui-static-config-mask-passwords branch from 65bed84 to c611992 Compare April 5, 2022 20:14
@holgerfriedrich
Copy link
Member Author

holgerfriedrich commented Apr 5, 2022 •
edited
Loading

Hi @ghys,

Thanks & sorry for the delay. Could you sort out the check warnings shown in the "Files changed" tab please?

Sorry I had overlooked this. Replacing the 'var' by 'const' resolved the warning.

ghys
ghys approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😀

@ghys ghys merged commit ea6726d into openhab:main Apr 5, 2022
@holgerfriedrich holgerfriedrich deleted the pr-ui-static-config-mask-passwords branch April 5, 2022 20:48
@ghys ghys added the main ui Main UI label May 1, 2022
@ghys ghys added this to the 3.3 milestone May 1, 2022
@ghys ghys added the enhancement New feature or request label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerfriedrich @ghys