Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of page action configuration option to override vars in target page #1394

Merged
merged 1 commit into from
May 20, 2022

Conversation

tarag
Copy link
Contributor

@tarag tarag commented May 19, 2022

Provides ability to transmit local context upon page switching. The target page is able to react to the calling page via the contents of the variable.

For example:
I have a canvas page with different layers for the ground floor (doors, hvac, lights) which visibility is managed through a var and buttons. It also has a button to navigate to the page for the second floor which has similar layers. Using this evolution I can select the same kind of layer when navigating across these 2 pages by overriding the var defining layer visibility.

…et page.

Signed-off-by: Gautier Taravella <tarag@mailbox.org>
@tarag tarag requested a review from a team as a code owner May 19, 2022 15:18
@relativeci
Copy link

relativeci bot commented May 19, 2022

Job #401: Bundle Size — 10.71MB (-0.02%).

bb5e51c vs 55cafb2

Changed metrics (3/10)
Metric Current Baseline
Initial JS 1.67MB(-0.13%) 1.67MB
Initial CSS 607.04KB(-0.04%) 607.27KB
Cache Invalidation 21.32% 15.78%
Changed assets by type (2/7)
            Current     Baseline
CSS 856.91KB (-0.03%) 857.14KB
JS 8.65MB (-0.03%) 8.65MB

View Job #401 report on app.relative-ci.com

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough, could probably use a doc update but then again, I don't believe defineVars at the page level is documented so it goes for both.
Thanks.

@ghys ghys merged commit 0e678f4 into openhab:main May 20, 2022
@ghys ghys added enhancement New feature or request main ui Main UI labels May 20, 2022
@ghys ghys added this to the 3.3 milestone May 20, 2022
@tarag tarag deleted the define-vars-page-transition branch May 23, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants