Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homekit] add support for parameter groups #1416

Merged
merged 1 commit into from
Jun 19, 2022
Merged

[homekit] add support for parameter groups #1416

merged 1 commit into from
Jun 19, 2022

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Jun 19, 2022

this PR

  • adds missing parameter for homekit accessory of type battery
  • adds support for parameters groups at complex accessories so that it is clear to which accessory parameter belongs

Signed-off-by: Eugen Freiter freiter@gmx.de

homekit add support for parameter groups
2114e38 
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre yfre requested a review from a team as a code owner June 19, 2022 14:43
@relativeci
Copy link

relativeci bot commented Jun 19, 2022

Job #436: Bundle Size — 10.74MB (0%).

cae76f2 vs 833e78e

Changed metrics (1/10)
Metric Current Baseline
Cache Invalidation 0.17% 2.97%
Changed assets by type (0/7)

No changes

View Job #436 report on app.relative-ci.com

ghys
ghys approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghys ghys merged commit ee30ec9 into openhab:main Jun 19, 2022
@ghys ghys added enhancement New feature or request main ui Main UI labels Jun 19, 2022
@ghys ghys added this to the 3.3 milestone Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yfre @ghys