[Basic UI] Add support for webaudio #1426
Conversation
|
Making a suggestion/pledge to make it opt-in as in #1422 (comment), because of the 6 max SSE connections per domain. Since Basic UI pages are generated server-side there could be an additional setting in the service configuration which would conditionally enable this code.
|
|
I agree with the need of an option. |
|
Config option added. ✔️ |
Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net>
|
I will test and review. |
|
@lolodomo if the changes don't work, make sure you have:
|
| @@ -42,6 +42,15 @@ | |||
| </options> | |||
| <default>false</default> | |||
| </parameter> | |||
| <parameter name="webAudio" type="text" required="true"> | |||
There was a problem hiding this comment.
You used the same pattern (text type) as for other parameters.
I do not understand why boolean type was not used for enableIcons, condensedLayout, ... parameters.
But your new parameter is at least coherent with others.
There was a problem hiding this comment.
Yes I kept the new parameter coherent with the other config parameters. It seems that @kaikreuzer added the inital config parameter in eclipse-archived/smarthome#540 like this. Maybe because it easier to understand (compared to a checkbox)?
|
Tested and working with barking.mp3 |
|
Thank you @wborn |
The Web Audio sink is now also supported by Main UI and Basic UI, see: * openhab/openhab-webui#1422 * openhab/openhab-webui#1426 Signed-off-by: Wouter Born <github@maindrain.net>
The Web Audio sink is now also supported by Main UI and Basic UI, see: * openhab/openhab-webui#1422 * openhab/openhab-webui#1426 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Wouter Born <github@maindrain.net>
|
Maybe you can add the "enhancement" label to this PR so this feature ends up in the final release notes @openhab/webui-maintainers ? |
Similar to #1422 but for Basic UI. 🙂