[habpanel] Use commandDescription instead of stateDescription for selection list #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Hilbush <mark@hilbush.com>
Signed-off-by: Mark Hilbush <mark@hilbush.com>
ghys
approved these changes
Feb 9, 2023
|
@lolodomo Would this be a candidate to back port to 3.4 if there's another patch release. |
kaikreuzer
pushed a commit
that referenced
this pull request
Feb 12, 2023
…ection list (#1688) Signed-off-by: Mark Hilbush <mark@hilbush.com>
|
I have cherry-picked this fix to the |
kaikreuzer
added
the
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1686
To be consistent with how Basic UI works, use commandDescription to populate the list used by the Selection widget. This will ensure that a selection list will be presented to the user if the item has state options or command options. This works because openHAB internally copies the state options to the command options when command options don't exist on the item.
Signed-off-by: Mark Hilbush mark@hilbush.com