Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Things by binding & pages by type not in alphabetical order #1884

Merged
merged 3 commits into from
May 9, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented May 8, 2023

Fixes #792.
Fixes #1673.

This fixes the Things by binding and pages by type order to always be alphentically.
These views only seemed to be alphabetically ordered in edge cases.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner May 8, 2023 16:25
@relativeci
Copy link

relativeci bot commented May 8, 2023

Job #976: Bundle Size — 15.76MiB (~+0.01%).

00e27e2(current) vs c2c93cd main#975(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (no changes)
                 Current
Job #976
     Baseline
Job #975
Initial JS 1.73MiB 1.73MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.95% 93.95%
Chunks 219 219
Assets 689 689
Modules 1719 1719
Duplicate Modules 85 85
Duplicate Code 1.73% 1.73%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #976
     Baseline
Job #975
CSS 858.62KiB 858.62KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.25MiB (~+0.01%) 9.25MiB
Media 295.6KiB 295.6KiB
Other 4.73MiB (~-0.01%) 4.73MiB

View job #976 reportView main branch activity

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels May 8, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone May 8, 2023
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this - it was indeed long overdue.

@ghys ghys merged commit 89d0403 into openhab:main May 9, 2023
@florian-h05
Copy link
Contributor Author

I had this on my list for a few weeks now, I noticed that issue several times before but did not look into it until I worked on the transformations list.

@florian-h05 florian-h05 deleted the fix-things-pages-order branch May 9, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Things not in alphabetical order on UI [MainUI] The 'By Binding' views should have a two level sort
2 participants