Persistence configuration page: Minor enhancements & fixes #1955
Conversation
Job #1069: Bundle Size — 15.75MiB (0%).Metrics (1 change)
Total size by type (no changes)
|
florian-h05
changed the title
|
@ghys Can you please review and merge this for openHAB 4? Probably to late for the feature freeze, but this PR contains a critical bug fix so IMO should be merged anyway. |
| <f7-list-button color="blue" :href="`https://${$store.state.runtimeInfo.buildString === 'Release Build' ? 'www' : 'next'}.openhab.org/docs/configuration/persistence.html`" external target="_blank"> | ||
| Open documentation | ||
| </f7-list-button> |
There was a problem hiding this comment.
A list button is not the best for linking to the docs IMHO, those are better suited for internal actions. For those concepts that are a little obscure and need a link to the docs a f7-link labeled "Learn more [about X]" or "About X" would be better, see the profile configuration for example (the blurb before the link can be optional):
or iOS settings (note how the list buttons does something while the documentation links are simply blue hyperlinks):
Also, as shown above for profiles (the www/next switch is missing there, sadly!) it would be better to create a openhab.org/link/persistence alias link or similar, that way if the docs are reorganized it wouldn't require a change in the code but only an update to the redirect. This happens here: https://github.com/openhab/website/blob/main/.vuepress/_redirects
There was a problem hiding this comment.
I've added a short paragraph with the link to the top and created a PR for the redirect, thanks for your feedback, looks much better now!
See openhab/website#413.
Required for openhab/openhab-webui#1955. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Depends on openhab/openhab-core#3681. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
This reverts commit 9def78f. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
… arrays on load Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Required for openhab/openhab-webui#1955. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Follow-up for #1917.