[basicui] Use command options for rendering Switch and Selection elements

[cweitkamp]

• Use command options for rendering Switch and Selection elements

Related to openhab/openhab-core#1016

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

[kaikreuzer]

As this is in some way breaking existing sitemaps of users: Should we maybe keep that change for 3.0 and commit it on master only?

[cweitkamp]

Yes, should be okay to merge it against master. I am not aware of any existing binding using command descriptions.

On the other hand I do not see a breaking change because the implementation of the getCommandDescription() method converts all existing StateOptions to CommandOptions in case no dedicated CommandDescription is provided.

https://github.com/openhab/openhab-core/blob/fb7a7ac42173d3228b7e4447582e827aa541e9ac/bundles/org.openhab.core/src/main/java/org/openhab/core/items/GenericItem.java#L415-L430

[kaikreuzer]

On the other hand I do not see a breaking change

Ok, fair point, so merging it here is ok for me.
But still: It'll be more important on master, so I hope you will port it and provide another PR there :-)

[cweitkamp]

@kaikreuzer Done (see #220). Easy going - thanks to cherry-pick.

[kaikreuzer]

That was quick, thanks :-)
Did the cherry picking work even though the namespace of classes has changed? I guess you needed to help this a bit to resolve!

[cweitkamp]

It worked in general. Yes, I had to solve merge conflicts due to namespace change. But only for the imports - which was not a big deal.

[lolodomo]

I think that the default should remain a selection. The buttons are not adapted when you have 50 options !

[cweitkamp]

The decision for the default element is done in OHC (openhab/openhab-core#1422).