-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering of command options #1016
Comments
I looked into this topic today and see what you are meaning. I tried to model some channel typed from Kodi binding to support command options instead of state option. Here is the result from my testings in Paper UI and Basic UI: Paper UI - command option are rendered as Push button(s) - state options are rendered as both Selection and Button(s): Basic UI - Both Selection and Switch elements are empty:
Maybe it is a simple change in the ItemUIRegistryImpl - Exchange But a little bit more theory in advance: State options are - in general - command options too. The getCommandDescription() first tries to return a command description, if none is found the state description will be converted to a matching command description. IIRC for both applies that dynamic descritons are preferred. What should be the Default element for command option? Selection too? Or just Push button(s) - because they have no state? To your questions - I additionally like to suggest to take the label and pattern into account.:
|
@ghys Can you give me a short insight in how the new UI handles CommandOptions? Otherwise I will add |
Simple: currently, it doesn't. But it's definitely something to consider and I suppose an action sheet would be an appropriate UI for those. |
Cool. Thanks. Looks nice. So it does not matter what we use here to solve this issue. |
Signed-off-by: Tim Roberts <troberts@bigfoot.com>
Command options is a new feature that is not yet supported neither in Basic UI nor in Classic UI. And I doubt it is in Android App too.
Before adding the support of this feature in Basic UI (and in few bindings), I would like to be sure to understand what is expected.
Command options can be different from state options.
I see 3 different cases:
I imagine the command options have to be considered when the user uses the switch or the selection sitemap element.
For the cases 1 and 2, we should render the command options as buttons for the switch element and as a selection for the selection element, the same as we do currently when having state options.
For the case 3, does it mean we have to consider command options + state options, meaning building one button for each command option + one button for each state option ? In this case, we have to consider only one item when one command option is the same as one item option ?
Last question is relative (again) to switch item. If I come back to my example, the clear queue channel is associated to a switch item. This channel should have only one command option: CLEAR. Is it acceptable for a switch element having command options to render it with buttons or a selection list ? I ask the question because it was recently rejected to render like that a switch item with state options. Or should we update the item type of this channel to String and only consider String and Number items for command options ?
@maniac103 @mueller-ma for Android App
The text was updated successfully, but these errors were encountered: