Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons store: Reduce size of addon card #2216

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

florian-h05
Copy link
Contributor

Proposal to fix #2205 and fix #1668.

Copy link

relativeci bot commented Dec 12, 2023

Job #1311: Bundle Size — 15.83MiB (+0.44%).

f33a79b(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1311
     Baseline
Job #1158
Regression  Initial JS 1.9MiB(+13.74%) 1.67MiB
Regression  Initial CSS 609.63KiB(+0.12%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3029(+78.18%) 1700
Regression  Duplicate Modules 170(+88.89%) 90
Improvement  Duplicate Code 1.6%(-17.95%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1311
     Baseline
Job #1158
Regression  JS 9.3MiB (+0.5%) 9.25MiB
Regression  Other 4.75MiB (+0.47%) 4.73MiB
Regression  CSS 861.05KiB (+0.18%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1311 reportView florian-h05:addon-logo-size branch activity

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Copy link
Contributor Author

This is how it looks (Click me to expand):

image
image
image
image
image

@ghys
Copy link
Member

ghys commented Dec 13, 2023

Thanks, good attempt. Maybe a few remarks here:

image

  • Could you just fix the horizontal gap between cards so that it matches the vertical one?

  • My concerns were firstly that most titles would be truncated (word-wrapping didn't look well), in the above screenshot that's okay because you can guess the truncated word, but in other cases (in the UI tab for instance) it's more difficult. I'm not opposed to a 2-column view for bindings etc. and a single-column view for UI widgets in those cards (with a parameter on the component). But in any case, in the end, the title truncating, well we can live with it. Another idea would be to just not display the "install/remove" button at least when space is too tight, as you can always go to the details and install from there.

  • Lastly I considered the fact that having 3 cards on 2 rows doesn't look too good (you have an empty space), but if we're not limiting the amount of "featured" add-ons to 3 in sections in the future then we can have what you find in "app store"-like UIs - a single line of horizontally-scrollable list of cards/ icons.

image

@florian-h05
Copy link
Contributor Author

Could you just fix the horizontal gap between cards so that it matches the vertical one?

I tried to fix that, while doing that, I noticed that the vertical gap actually was not to large, but there was no horizontal gap left.

My concerns were firstly that most titles would be truncated (word-wrapping didn't look well), in the above screenshot that's okay because you can guess the truncated word, but in other cases (in the UI tab for instance) it's more difficult.

Yes, that's not nice, but I don't have a better idea ...

I'm not opposed to a 2-column view for bindings etc. and a single-column view for UI widgets in those cards (with a parameter on the component).

The problem is, that this is controlled by CSS, so it is not that easy to control it from JS.

Another idea would be to just not display the "install/remove" button at least when space is too tight, as you can always go to the details and install from there.

I have had a look at this, it feels a bit weird to not have the install/remove button for those, but for the list.

Lastly I considered the fact that having 3 cards on 2 rows doesn't look too good (you have an empty space), but if we're not limiting the amount of "featured" add-ons to 3 in sections in the future then we can have what you find in "app store"-like UIs - a single line of horizontally-scrollable list of cards/ icons.

That is a really nice proposal.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI rendering/scaling of logos for suggested add-ons Why so big logo for addons and why different sizes ?
2 participants