Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve network-interface context support #2246

Merged
merged 3 commits into from Jan 6, 2024
Merged

Improve network-interface context support #2246

merged 3 commits into from Jan 6, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Dec 29, 2023

This allows for selecting multiple network interface names in configuration parameters.

Related to:

@wborn
Improve network-interface context support
e665441 
This allows for selecting multiple network interface names in configuration parameters.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team as a code owner December 29, 2023 23:53
@florian-h05 florian-h05 added main ui Main UI awaiting other PR Depends on another PR labels Dec 29, 2023
@relativeci RelativeCI
Copy link

relativeci bot commented Dec 29, 2023 •
edited

Job #1343: Bundle Size — 15.84MiB (+0.52%).

7b9273c(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1343		      Baseline
Job #1158
Regression  Initial JS 1.9MiB(+13.83%) 1.67MiB
Regression  Initial CSS 609.81KiB(+0.15%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3036(+78.59%) 1700
Regression  Duplicate Modules 170(+88.89%) 90
Improvement  Duplicate Code 1.6%(-17.95%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1343		      Baseline
Job #1158
Regression  JS 9.31MiB (+0.6%) 9.25MiB
Regression  Other 4.75MiB (+0.53%) 4.73MiB
Regression  CSS 861.35KiB (+0.22%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1343 report View wborn:network-interface-context branch activity

@wborn
Copy link
Member Author

wborn commented Jan 3, 2024

Both PRs got merged now.

@wborn wborn mentioned this pull request Jan 5, 2024
Merged
@kaikreuzer kaikreuzer removed the awaiting other PR Depends on another PR label Jan 5, 2024
kaikreuzer
kaikreuzer approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 225e61c into openhab:main Jan 6, 2024
6 checks passed
kaikreuzer pushed a commit that referenced this pull request Jan 6, 2024
@wborn @kaikreuzer
Improve network-interface context support (#2246)
6e04d9a 
This allows for selecting multiple network interface names in
configuration parameters.

Related to:

* openhab/openhab-core#3981
* openhab/openhab-addons#16145

Signed-off-by: Wouter Born <github@maindrain.net>
@kaikreuzer
Copy link
Member

Cherry-picked to 4.1.x.

@kaikreuzer kaikreuzer added the patch A PR that has been cherry-picked to a patch release branch label Jan 6, 2024
@wborn wborn deleted the network-interface-context branch January 6, 2024 10:40
florian-h05
florian-h05 reviewed Jan 6, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaikreuzer Thanks for already merging and backporting this PR.

@florian-h05 florian-h05 added the enhancement New feature or request label Jan 6, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 left review comments

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wborn @kaikreuzer @florian-h05