New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network-interface context #3981
Conversation
This allows for selecting network interface names in configuration parameters. Signed-off-by: Wouter Born <github@maindrain.net>
Could this also be used by the suggestion finders to limit the interfaces for scanning? Or by UPnP, mDNS. Or does use of the context limits it to use as binding parameters? |
You can use contexts with any
Just add
The values are just text so it should work. The context is used to define the available options. This can then be used by UIs to present configuration options and by the framework to validate values.
Maybe as a default value instead of always using every available interface which can be many when using Docker. But you can still have the situation where you want to use one network interface most of the time but still want to have the option to only use some network interfaces other times e.g. when using arping to see if a container is up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This context was added in openhab/openhab-core#3981. Signed-off-by: Wouter Born <github@maindrain.net>
This context was added in openhab/openhab-core#3981. Signed-off-by: Wouter Born <github@maindrain.net>
This allows for selecting network interface names in configuration parameters. Signed-off-by: Wouter Born <github@maindrain.net>
Cherry-picked to |
This allows for selecting multiple network interface names in configuration parameters. Related to: * openhab/openhab-core#3981 * openhab/openhab-addons#16145 Signed-off-by: Wouter Born <github@maindrain.net>
This allows for selecting multiple network interface names in configuration parameters. Related to: * openhab/openhab-core#3981 * openhab/openhab-addons#16145 Signed-off-by: Wouter Born <github@maindrain.net>
This context was added in openhab/openhab-core#3981. Signed-off-by: Wouter Born <github@maindrain.net>
This allows for selecting network interface names in configuration parameters.
Just add
<context>network-interface</context>
to your config parameter similar to<context>serial-port</context>
.