Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update descriptions in the settings menu #2273

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

ghys
Copy link
Member

@ghys ghys commented Jan 14, 2024

I thought these labels could be improved and those describe the relevant sections better IMO, getting more to the point. Native English speakers, please confirm and review!

I thought these labels could be improved and those describe the relevant sections better IMO, getting more to the point.
Native English speakers, please confirm and review!

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys ghys requested a review from a team as a code owner January 14, 2024 23:45
Copy link

relativeci bot commented Jan 14, 2024

Job #1357: Bundle Size — 15.84MiB (~-0.01%).

92f6083(current) vs ef52364 main#1356(baseline)

Warning

Bundle contains 16 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1357
     Baseline
Job #1356
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 609.81KiB 609.81KiB
Change  Cache Invalidation 93.98% 93.81%
No change  Chunks 217 217
No change  Assets 683 683
No change  Modules 3036 3036
No change  Duplicate Modules 170 170
No change  Duplicate Code 1.6% 1.6%
No change  Packages 152 152
No change  Duplicate Packages 16 16
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
Job #1357
     Baseline
Job #1356
Improvement  JS 9.31MiB (~-0.01%) 9.31MiB
Improvement  Other 4.75MiB (~-0.01%) 4.75MiB
Not changed  CSS 861.35KiB 861.35KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1357 reportView settings-menu-labels branch activityView project dashboard

@ghys
Copy link
Member Author

ghys commented Jan 14, 2024

Btw, we have to check why the bundle metrics are like:

  CurrentJob #1349 BaselineJob #1158
Initial JS 1.9MiB(+13.82%) 1.67MiB

I think the baseline hasn't changed since #2063.
@vio could you confirm and tell us how to update it with every PR?

In any case 300kB more initial JS is a lot in 4 months; we'll have to investigate why it happened.

@vio
Copy link
Contributor

vio commented Jan 15, 2024

@ghys the baseline is the latest job in the default branch at the time of the build. Looks like your latest job in the default branch (main) was processed on 16/09/2023 16:28:44: https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/tree/main.

The Main UI workflow runs only on pull-request and on workflow_dispatch, so the push to main is ignored atm. To run the workflow and send the latest from main, you need to trigger the workflow manually or update the workflow to build and send the data on push for the main branch

https://github.com/openhab/openhab-webui/blob/main/.github/workflows/mainui.yml#L3

+  push:
+    branches: [ main ]
+    paths: bundles/org.openhab.ui/web/**
+
   pull_request:
-    branches: [ main ]
     paths: bundles/org.openhab.ui/web/**

  workflow_dispatch:

@florian-h05
Copy link
Contributor

@vio Thx for pointing out what to do.
I have now triggered a manual run, then triggered a re-run of the Main UI action on this PR and the bundle stats look fine again. I will update the workflow file in #2278.

@ghys I have tried to find out what caused the initial CS bundle-size increase, and it is not easy to find out the cause from checking the RelativeCI history, but it seems that #2088 at least lead to some increase. #2253 will help with that.

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
But I am no native English speaker, so let's ping one @rkoshak.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 17, 2024
@JustinGeorgi
Copy link
Contributor

The english all looks just fine.

@florian-h05 florian-h05 merged commit c89614d into main Jan 18, 2024
6 checks passed
@florian-h05 florian-h05 deleted the settings-menu-labels branch January 18, 2024 00:25
@florian-h05 florian-h05 added this to the 4.2 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants