Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Add-on Management UI with Add-on Store #1158

Merged
merged 7 commits into from
Sep 24, 2021
Merged

Conversation

ghys
Copy link
Member

@ghys ghys commented Sep 7, 2021

Depends on openhab/openhab-core#2405.

This replaces the current section of the UI for managing
add-ons with a completely new "store-like" interface.
External data, like logos and detailed descriptions for
distribution add-ons are fetched from well-known locations
on the website or GitHub to provide a "store" look & feel.

The add-on store is orgnanized around 4 categories: bindings,
automation, UI, and others, with a separate search tab.
Each category is splitted into subsections. The availability
of these sections depend on the add-on services that are
registered. The sections currently supports add-ons provided
by the "karaf" & "marketplace" services, as provided by
openhab/openhab-core#2405.

Signed-off-by: Yannick Schaus github@schaus.net

Depends on openhab/openhab-core#2405.

This replaces the current section of the UI for managing
add-ons with a completely new "store-like" interface.
External data, like logos and detailed descriptions for
distribution add-ons are fetched from well-known locations
on the website or GitHub to provide a "store" look & feel.

The add-on store is orgnanized around 4 categories: bindings,
automation, UI, and others, with a separate search tab.
Each category is splitted into subsections. The availability
of these sections depend on the add-on services that are
registered. The sections currently supports add-ons provided
by the "karaf" & "marketplace" services, as provided by
openhab/openhab-core#2405.

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys ghys requested a review from a team as a code owner September 7, 2021 09:18
@ghys
Copy link
Member Author

ghys commented Sep 7, 2021

Screenshots

store1

store2

store3

store4

store5

store6

store7

store8

store9

store10

@relativeci
Copy link

relativeci bot commented Sep 7, 2021

Job #207: Bundle Size — 10.58MB (~+0.01%).

1be08d6 vs 9fafcfc

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 0.85% 26.32%
Changed assets by type (2/7)
            Current     Baseline
CSS 845.32KB (~+0.01%) 845.28KB
JS 8.31MB (~+0.01%) 8.31MB

View Job #207 report on app.relative-ci.com

@hmerk
Copy link

hmerk commented Sep 7, 2021

Excellent !!!!!!

Refactor info table to include it in the addon sheet.
Add author to info table

Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Rename labels in info table, swap colors
Add link to docs/forum when clicking on the big logo
on the details page.

Change compare logic when stats are present.

Signed-off-by: Yannick Schaus <github@schaus.net>
@hmerk
Copy link

hmerk commented Sep 9, 2021

@ghys As I still need to provide some icons with my next version of the ConnectedCarDashboard widget, did you already consider how to make those icons available/installable ?
Would it be feasable to point to a github repo like .../ConnectedCarDashboard/icons/ and copy all existing PNG or SVG icons into openHAB's icon folder ?

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys
Copy link
Member Author

ghys commented Sep 9, 2021

@ghys As I still need to provide some icons with my next version of the ConnectedCarDashboard widget, did you already consider how to make those icons available/installable ?
Would it be feasable to point to a github repo like .../ConnectedCarDashboard/icons/ and copy all existing PNG or SVG icons into openHAB's icon folder ?

Yes: openhab/openhab-core#2405 (comment)
That would be solely the duty of the backend marketplace handler though, this PR is only for the UI which only triggers the installation through the API and is oblivious to what should actually be done.

@hmerk
Copy link

hmerk commented Sep 9, 2021

Thanks @ghys and sorry for bothering you again ;-)

@wborn
Copy link
Member

wborn commented Sep 20, 2021

It works very well for me. 🙂 👍

It would also be nice if the UI showed the "Created At" and "Updated At" times in your own timezone instead of UTC.

E.g. it shows:

store

For these created/updated times shown in the Community post:

created

edited

@wborn
Copy link
Member

wborn commented Sep 20, 2021

Another thing I noticed is that if you click "Install More Bindings" in the Add Thing dialog (/settings/things/add), you end up at an old bindings list view (/settings/things/add/install-binding) and not the bindings add-on store grid with icons that also lists Marketplace entries.

@wborn
Copy link
Member

wborn commented Sep 21, 2021

It's also no longer possible to use the UI to get to binding configuration settings. E.g. in the UI before these changes the Chromecast Binding has a "Configure" link:

configure

Add KAR archive content type label
Change label based on content type ("Install" or "Add")
Display dates in local time in info table
Route to store from the links in "choose binding" page
Add configure link for installed & configurable Karaf addons
Add warnings in addon sheet if unpublished or unverified
Display non-Karaf add-ons in all sections
Cleanups, cosmetics

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys
Copy link
Member Author

ghys commented Sep 24, 2021

This PR should be ready now. Thanks @wborn for the comments!

@wborn
Copy link
Member

wborn commented Sep 24, 2021

Thank you for fixing my comments @ghys! 👍 I haven't found anything else and agree it is ready. :-)

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys ghys merged commit 11b9bbe into openhab:main Sep 24, 2021
@ghys ghys added enhancement New feature or request main ui Main UI labels Sep 24, 2021
@ghys ghys added this to the 3.2 milestone Sep 24, 2021
@mvalla
Copy link

mvalla commented Oct 3, 2021

Why version is not shown in the summary view? I think expecially for external (marketplace) bindings having the version number is important.
Maybe one can find on the marketplace different (beta) versions and therefore choose which one to install from the summary view. Same could apply for rule templates and widgets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants