Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blockly] Fix persistence block ZDT disconnection #2306

Merged
merged 1 commit into from Feb 13, 2024
Merged

[blockly] Fix persistence block ZDT disconnection #2306

merged 1 commit into from Feb 13, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 6, 2024

Fix so oh_get_persistvalue block does not unnecessarily disconnect the ZDT input every time a different methodname is selected.

@jimtng jimtng requested a review from a team as a code owner February 6, 2024 01:38
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 6, 2024 •
edited

Job #1450: Bundle Size — 11MiB (~+0.01%).

61a2635(current) vs 362d9f3 main#1449(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1450		      Baseline
Job #1449
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 17.04% 16.98%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3074 3074
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.74% 1.74%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1450		      Baseline
Job #1449
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1450 report View jimtng:blockly-persistence-fix branch activity View project dashboard

@jimtng jimtng force-pushed the blockly-persistence-fix branch 2 times, most recently from d93300f to 4b0b18b Compare February 7, 2024 10:54
@jimtng
[blockly] Fix get persistence block disconnection
61a2635 
Fix so oh_get_persistvalue block does not unnecessarily disconnect the ZDT input every time a different methodname is selected.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
florian-h05
florian-h05 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 changed the title [blockly] Fix get persistence block disconnection [blockly] Fix persistence block ZDT disconnection Feb 13, 2024
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Feb 13, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 13, 2024
@florian-h05 florian-h05 merged commit 979bfb1 into openhab:main Feb 13, 2024
6 checks passed
@jimtng jimtng deleted the blockly-persistence-fix branch February 14, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimtng @florian-h05