Script editor: Add commenting/uncommenting with Ctrl-/ and Cmd-/

[jimtng]

Resolve #1336

[relativeci]

Job #1454: Bundle Size — 11MiB (+0.03%).

0a98c9f(current) vs 362d9f3 main#1449(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics   3 changes 1 regression

	Current Job #1454	Baseline Job #1449
Initial JS	1.84MiB(~+0.01%)	1.84MiB
Initial CSS	607.73KiB	607.73KiB
Cache Invalidation	19.66%	16.98%
Chunks	220	220
Assets	242	242
Modules	3075(+0.03%)	3074
Duplicate Modules	159	159
Duplicate Code	1.74%	1.74%
Packages	150	150
Duplicate Packages	18	18

Bundle size by type   1 change 1 regression

	Current Job #1454	Baseline Job #1449
JS	9.19MiB (+0.04%)	9.19MiB
CSS	888.86KiB	888.86KiB
Fonts	526.1KiB	526.1KiB
Media	295.6KiB	295.6KiB
IMG	140.74KiB	140.74KiB
HTML	1.24KiB	1.24KiB
Other	871B	871B

---

View job #1454 report View jimtng:code-editor-commenting branch activity View project dashboard

[florian-h05]

LGTM, thanks.
Using these keyboard shortcuts sounds reasonable.

Do you think this should be documented somewhere?

[jimtng]

Do you think this should be documented somewhere?

I am unfamiliar with the documentation in general. Where should it go?
Even better, is to show a list/table of shortcut keys on the UI itself, with a little question mark icon or something. That would get read far more than if it's buried somewhere in openhab.org/docs/ somewhere.

[florian-h05]

In #2253 I migrated the docs of the UI-integrated help feature (which is opened by clicking the question mark in the upper right corner) to the docs repo.
The UI now loads the docs from the docs repo (see openhab/openhab-docs#2199), so I wonder if we could utilise this feature for your suggested shortcuts list.

We can now create a page in the docs, which is displayed on the website and accessible inside the UI, we just need to figure out how the help feature can determine that currently the script editor is open. If we have a reliable way to check that, we just have to write the docs and add a one-liner to the UI and we will have the docs.

[rkoshak]

Maybe this could be integrated with the Help tab in the Developer Sidebar too?

[florian-h05]

Maybe this could be integrated with the Help tab in the Developer Sidebar too?

This is what I was talking about ;-)

[florian-h05]

@jimtng See #2331 and the linked docs PR for the docs.

[jimtng]

@florian-h05 in the sidebar help for script editor, it has a link to Codemirror docs, but it's broken. Can't click on it.

[florian-h05]

@jimtng Please have a look at #2368 for the fix.

[jimtng]

@jimtng Please have a look at #2368 for the fix.

Thanks! That seems to have fixed it