New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only load ignored inbox items in inbox view #2400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #1812: Bundle Size — 11.15MiB (~+0.01%).Warning Bundle contains 19 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1812 report View seime:skip_ignored_things_in_inb... branch activity View project dashboard |
florian-h05
added
enhancement
New feature or request
main ui
Main UI
awaiting other PR
Depends on another PR
labels
Feb 23, 2024
@seime Does this need ajustments after the merge of the core PR? |
Yes, coming
…On Fri, Mar 15, 2024, 17:10 Florian Hotze ***@***.***> wrote:
@seime <https://github.com/seime> Does this need ajustments after the
merge of the core PR?
—
Reply to this email directly, view it on GitHub
<#2400 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL6DZBMY3OR6GVJVUVFXHDYYMMQJAVCNFSM6AAAAABDWT4EGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZHE4DQOJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
seime
force-pushed
the
skip_ignored_things_in_inbox
branch
from
March 16, 2024 15:05
c062b25
to
61c03b4
Compare
…filtering due to changed default behaviour Signed-off-by: Arne Seime <arne.seime@gmail.com>
Signed-off-by: Arne Seime <arne.seime@gmail.com>
seime
force-pushed
the
skip_ignored_things_in_inbox
branch
from
March 16, 2024 15:15
61c03b4
to
37af555
Compare
florian-h05
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
florian-h05
changed the title
[mainui] Only load ignored inbox items in inbox view
Only load ignored inbox items in inbox view
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on openhab/openhab-core#4108.
In most places, the inbox content is loaded only to show a count of items in inbox.
For any decent size systems the inbox may contain hundreds of entries that are ignored,
which equates to lots of unnecessary data being transferred and processed in the browser.