Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load ignored inbox items in inbox view #2400

Merged
merged 2 commits into from Mar 18, 2024

Conversation

seime
Copy link
Contributor

@seime seime commented Feb 23, 2024

Depends on openhab/openhab-core#4108.

In most places, the inbox content is loaded only to show a count of items in inbox.
For any decent size systems the inbox may contain hundreds of entries that are ignored,
which equates to lots of unnecessary data being transferred and processed in the browser.

@seime seime requested a review from a team as a code owner February 23, 2024 12:17
Copy link

relativeci bot commented Feb 23, 2024

Job #1812: Bundle Size — 11.15MiB (~+0.01%).

37af555(current) vs 021c3d8 main#1808(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1812
     Baseline
Job #1808
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.88KiB 607.88KiB
Change  Cache Invalidation 17.34% 18.73%
No change  Chunks 219 219
No change  Assets 242 242
No change  Modules 3051 3051
No change  Duplicate Modules 144 144
No change  Duplicate Code 1.69% 1.69%
No change  Packages 153 153
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1812
     Baseline
Job #1808
Regression  JS 9.34MiB (~+0.01%) 9.34MiB
Not changed  CSS 889.25KiB 889.25KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1812 reportView seime:skip_ignored_things_in_inb... branch activityView project dashboard

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI awaiting other PR Depends on another PR labels Feb 23, 2024
@florian-h05 florian-h05 removed the awaiting other PR Depends on another PR label Mar 15, 2024
@florian-h05
Copy link
Contributor

@seime Does this need ajustments after the merge of the core PR?

@seime
Copy link
Contributor Author

seime commented Mar 16, 2024 via email

@seime seime force-pushed the skip_ignored_things_in_inbox branch from c062b25 to 61c03b4 Compare March 16, 2024 15:05
…filtering due to changed default behaviour

Signed-off-by: Arne Seime <arne.seime@gmail.com>
Signed-off-by: Arne Seime <arne.seime@gmail.com>
@seime seime force-pushed the skip_ignored_things_in_inbox branch from 61c03b4 to 37af555 Compare March 16, 2024 15:15
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added this to the 4.2 milestone Mar 18, 2024
@florian-h05 florian-h05 merged commit f784419 into openhab:main Mar 18, 2024
6 checks passed
@florian-h05 florian-h05 changed the title [mainui] Only load ignored inbox items in inbox view Only load ignored inbox items in inbox view Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants