[rest] Allow skipping ignored things in inbox #4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general that sounds like a good idea, but wouldn't it make sense to have the default |
|
Maybe, but of the about 4 places in MainUI it was being used, only 1 usage needed the ignored ones. I'm not aware of any other places that utilize this API other than MainUI, but obviosly I cannot be sure. Are you aware of any? |
|
I'm not sure if 3rd party services (like HABApp) use these parts of the API. But in general we should avoid unnecessary breaking changes. |
|
Thanks for thinking about the HABApp users. |
Signed-off-by: Arne Seime <arne.seime@gmail.com>
Signed-off-by: Arne Seime <arne.seime@gmail.com>
Signed-off-by: Arne Seime <arne.seime@gmail.com>
seime
force-pushed
the
skip_ignored_things_in_inbox
branch
from
7f3abd9
to
180e4a3
Compare
J-N-K
changed the title
florian-h05
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Mar 18, 2024
Depends on openhab/openhab-core#4108. In most places, the inbox content is loaded only to show a count of items in inbox. For any decent size systems the inbox may contain hundreds of entries that are ignored, which equates to lots of unnecessary data being transferred and processed in the browser. --------- Signed-off-by: Arne Seime <arne.seime@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a default filter to skip ignored inbox items.
Most of the calls from MainUI uses inbox data only to show the number of non-ignored inbox items. On any decent sized installation, the inbox contains hundreds of ignored items that currently is being transferred.
Only when an optional request parameter is passed, the ignored entires are returned.
This PR will be followed by a companion PR in the MainUI repo shortly.