Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show lock icon in the item details members list #2410

Merged
merged 1 commit into from Mar 3, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 25, 2024

Depends on openhab/openhab-core#4118.

@ghys could you comment on the purpose of ignoreEditable here? It's preventing the lock icon from showing up.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner February 25, 2024 14:41
Copy link

relativeci bot commented Feb 25, 2024

Job #1682: Bundle Size — 11.01MiB (~-0.01%).

a8dc0ec(current) vs 3b694d2 main#1679(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1682
     Baseline
Job #1679
No change  Initial JS 1.85MiB 1.85MiB
No change  Initial CSS 607.92KiB 607.92KiB
Change  Cache Invalidation 17.6% 22.84%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3088 3088
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1682
     Baseline
Job #1679
Improvement  JS 9.2MiB (~-0.01%) 9.2MiB
Not changed  CSS 889.38KiB 889.38KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1682 reportView jimtng:show-members-locked branch activityView project dashboard

@ghys
Copy link
Member

ghys commented Feb 26, 2024

I'm not sure, it seems it was an option that was just used for the group members component:

https://github.com/search?q=repo%3Aopenhab%2Fopenhab-webui%20ignoreEditable&type=code
https://github.com/search?q=repo%3Aopenhab%2Fopenhab-webui+ignore-editable&type=code

I really can't recall why.

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good, unfortunately it seems that the /rest/items/[itemname] endpoint does not return the editable state for the group Item members. I will have a look at adjusting that.

@jimtng
Copy link
Contributor Author

jimtng commented Feb 28, 2024

It seems to work for me, showing the lock icons

@florian-h05
Copy link
Contributor

For me, it also show the lock Item for an Item that is editable, which should not happen.

@jimtng
Copy link
Contributor Author

jimtng commented Feb 28, 2024

Haha great catch! All my items are from file, so I didn't check this case. This explains the original code for ignore-editable!

@florian-h05
Copy link
Contributor

openhab/openhab-core#4118 sets the required editable property of the group's members.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI awaiting other PR Depends on another PR labels Feb 28, 2024
@kaikreuzer kaikreuzer removed the awaiting other PR Depends on another PR label Mar 3, 2024
@kaikreuzer kaikreuzer merged commit 61aa3d8 into openhab:main Mar 3, 2024
6 checks passed
@kaikreuzer kaikreuzer added this to the 4.2 milestone Mar 3, 2024
@jimtng jimtng deleted the show-members-locked branch March 3, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants