New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show lock icon in the item details members list #2410
Conversation
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Job #1682: Bundle Size — 11.01MiB (~-0.01%).Warning Bundle contains 19 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1682 report View jimtng:show-members-locked branch activity View project dashboard |
I'm not sure, it seems it was an option that was just used for the group members component: https://github.com/search?q=repo%3Aopenhab%2Fopenhab-webui%20ignoreEditable&type=code I really can't recall why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise looks good, unfortunately it seems that the /rest/items/[itemname]
endpoint does not return the editable state for the group Item members
. I will have a look at adjusting that.
It seems to work for me, showing the lock icons |
For me, it also show the lock Item for an Item that is editable, which should not happen. |
Haha great catch! All my items are from file, so I didn't check this case. This explains the original code for |
openhab/openhab-core#4118 sets the required |
Depends on openhab/openhab-core#4118.
@ghys could you comment on the purpose of
ignoreEditable
here? It's preventing the lock icon from showing up.