[rest] Set editable for members of an item #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required by the UI. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
commented
Feb 28, 2024
| @@ -317,7 +323,7 @@ public Response getItemNamespaces(@PathParam("itemname") @Parameter(description | |||
| @Operation(operationId = "getItemByName", summary = "Gets a single item.", responses = { | |||
| @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = EnrichedItemDTO.class))), | |||
| @ApiResponse(responseCode = "404", description = "Item not found") }) | |||
| public Response getItemData(final @Context UriInfo uriInfo, final @Context HttpHeaders httpHeaders, | |||
| public Response getItemByName(final @Context UriInfo uriInfo, final @Context HttpHeaders httpHeaders, | |||
There was a problem hiding this comment.
FYI I decided to rename that method to better reflect what it is actually doing.
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@kaikreuzer This PR would also be nice to have for the snapshot, as it is required to fix an UI bug. |
kaikreuzer
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Mar 3, 2024
Depends on openhab/openhab-core#4118. @ghys could you comment on the purpose of `ignoreEditable` here? It's preventing the lock icon from showing up. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the
editablefield of theEnrichedItemDTOformembersof theEnrichedGroupItemDTO.The
editablefield is needed by the UI, e.g. for openhab/openhab-webui#2410.