Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cordova from Main UI #2432

Merged
merged 1 commit into from Feb 29, 2024
Merged

Conversation

florian-h05
Copy link
Contributor

This removes Cordova from Main UI.

Cordova was used to build Main UI as an iOS or Android app (a webview with pre-packed assets), but the Cordova component of Main UI is currently unmaintained due to requiring lots of maintenance.
Both the iOS and the Android app have an integrated webview (without pre-packed assets though), so Cordova is unlikely to be required in the future.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 29, 2024 10:17
@florian-h05 florian-h05 changed the title Remove abandoned & outdated Cordova code Remove Corodova from Main UI Feb 29, 2024
@florian-h05 florian-h05 added the main ui Main UI label Feb 29, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 29, 2024
@florian-h05 florian-h05 changed the title Remove Corodova from Main UI Remove Cordova from Main UI Feb 29, 2024
Copy link

relativeci bot commented Feb 29, 2024

Job #1734: Bundle Size — 11.1MiB (-0.07%).

e7d54b3(current) vs d6097a6 main#1732(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Improvement 2 improvements
                 Current
Job #1734
     Baseline
Job #1732
Improvement  Initial JS 1.84MiB(-0.43%) 1.85MiB
Improvement  Initial CSS 607.88KiB(~-0.01%) 607.92KiB
Change  Cache Invalidation 22.05% 16.87%
No change  Chunks 220 220
No change  Assets 242 242
Change  Modules 3090(-0.19%) 3096
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.75% 1.75%
No change  Packages 151 151
No change  Duplicate Packages 18 18
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
Job #1734
     Baseline
Job #1732
Improvement  JS 9.29MiB (-0.09%) 9.3MiB
Improvement  CSS 889.34KiB (~-0.01%) 889.38KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1734 reportView florian-h05:remove-cordova branch activityView project dashboard

@florian-h05 florian-h05 merged commit ea28f32 into openhab:main Feb 29, 2024
6 checks passed
@florian-h05 florian-h05 deleted the remove-cordova branch February 29, 2024 10:26
@stefan-hoehn
Copy link
Contributor

Very nice. Again something tha reduces complexity. Thanks a lot, Florian 👏🏻

@florian-h05 florian-h05 added the enhancement New feature or request label Mar 2, 2024
florian-h05 added a commit that referenced this pull request Mar 4, 2024
Regression from #2432.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants