Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings menu: Fix back-link #2449

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Settings menu: Fix back-link #2449

merged 1 commit into from
Mar 4, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Mar 4, 2024 •
edited

Regression from #2432.

@florian-h05
Settings menu: Fix back-link
3ca316e 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner March 4, 2024 18:38
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 4, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 4, 2024

Job #1770: Bundle Size — 11.13MiB (~-0.01%).

3ca316e(current) vs 74620c3 main#1767(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1770		      Baseline
Job #1767
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.88KiB 607.88KiB
Change  Cache Invalidation 16.76% 16.53%
No change  Chunks 220 220
No change  Assets 243 243
No change  Modules 3091 3091
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.75% 1.75%
No change  Packages 151 151
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1770		      Baseline
Job #1767
Improvement  JS 9.31MiB (~-0.01%) 9.31MiB
Not changed  CSS 889.35KiB 889.35KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1770 report View florian-h05:settings-fix-back-na... branch activity View project dashboard

@florian-h05 florian-h05 merged commit ccaa221 into openhab:main Mar 4, 2024
6 checks passed
@florian-h05 florian-h05 deleted the settings-fix-back-nav branch March 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
main ui Main UI regression
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@florian-h05