Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things (inbox) list: Improve condition for reversed checkbox style #2512

Merged
merged 1 commit into from Mar 30, 2024

Conversation

florian-h05
Copy link
Contributor

Follow-up for #2472.

Improve the condition to only show the reversed order where really required.

Follow-up for openhab#2472.

Improve the condition to only show the reversed order where really required.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner March 30, 2024 11:51
@florian-h05 florian-h05 added the main ui Main UI label Mar 30, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 30, 2024
@florian-h05 florian-h05 added the enhancement New feature or request label Mar 30, 2024
Copy link

relativeci bot commented Mar 30, 2024

Job #1879: Bundle Size — 10.56MiB (~+0.01%).

3b34208(current) vs 2539d6d main#1878(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1879
     Baseline
Job #1878
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 18.3% 17.91%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2861 2861
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 95 95
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1879
     Baseline
Job #1878
Regression  JS 8.75MiB (~+0.01%) 8.75MiB
Not changed  CSS 890.07KiB 890.07KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1879 reportView florian-h05:follow-up-2472 branch activityView project dashboard

@florian-h05 florian-h05 merged commit 673ef9b into openhab:main Mar 30, 2024
6 checks passed
@florian-h05 florian-h05 deleted the follow-up-2472 branch March 30, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant