Test if Amanda storage area is writable #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Storm <markus.storm@gmx.net>
ecdye
changed the title
ecdye
requested changes
Jan 6, 2022
functions/backup.bash
Outdated
Comment on lines
183
to
184
| if ! cond_redirect sudo -u "${backupUser}" "touch ${storageLoc}/TEST"; then echo "FAILED (storage write access for user backup)"; return 1; fi | ||
| rm -f "${storageLoc}/TEST" |
There was a problem hiding this comment.
Wouldn't we want this after we change the permissions of the backup user, ie move to after line 186?
There was a problem hiding this comment.
right, I now combined those
Signed-off-by: Markus Storm <markus.storm@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1640
Signed-off-by: Markus Storm markus.storm@gmx.net