Add support for installing openhab & openhab_rules_tools from npm
#1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-h05
force-pushed
the
add-openhab-node-packages
branch
5 times, most recently
from
a85c42e
to
6430bcc
Compare
|
@mstormi At every start of the
In the I only need your help where to put the command for auto-installing |
mstormi
requested changes
Sep 14, 2022
florian-h05
requested review from
rkoshak and
mstormi
and removed request for
mstormi and
rkoshak
|
Short of being able to test this myself all I can say is LGTM. |
|
I tested all recent changes just a few minutes ago, everything works. Should be ready for merging @mstormi. |
|
please rebase to include a fix I've just to main (it should make the installation tests pass) |
mstormi
requested changes
Sep 17, 2022
florian-h05
force-pushed
the
add-openhab-node-packages
branch
from
3b705af
to
2e610c0
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Fixes openhab#1651. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
This change indicates that openhab-js is included in JS Scripting and can be upgraded manually, but does not have to be installed manually. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
force-pushed
the
add-openhab-node-packages
branch
from
70a2b21
to
8fc27b5
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Fixes an issue, where the regex matches on a different package, that included the package name Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@mstormi |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@mstormi
|
florian-h05
added a commit
to openhab/openhab-js
that referenced
this pull request
Sep 25, 2022
This updates the README to explain the openhab-js installation using the openhabian-config tool. Reference openhab/openhabian#1714. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
There's a branch inside openhabian-setup.sh that's executed for unattended installs. Put it somewhere after openhab installation.Am 13.09.2022 15:24 schrieb Florian Hotze ***@***.***>:
@mstormi
This is nearly ready for merging.
At every start of the openhabian-config tool, it checks the following for both openhab & openhab_rules_tools:
Does the package folder exist? If not, exit.Run npm outdated and check for the package name in the output. If the package is mentioned in the output, an update is available.Ask the user for updating.
In the openhabian-config tool, you can install both packages under 40 | openHAB Related.
I only need your help where to put the command for auto-installing openhab_rules_tools.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1651.
This PR adds a menu option to install the openHAB JavaScript library and
openhab_rules_toolsfrom @rkoshak.