Remove NTP Setup from openHABian setup as it is now redundant #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment out setup_ntp to test
Some users have reported problems with NTP on openhabian where systemd-timesyncd fails due to excess starts. It appears that Raspberry Pi OS now includes NTP by default, so this can be removed from openHABian setup.
mstormi
requested changes
May 15, 2023
|
Could you please fix what I mentioned above so we can merge this in time for OH4 ? Thanks |
As requested by Marcus, remove enable/disable NTP from menu bash, in conjunction with removing it from openhabian install as it is now part of base Raspberry Pi OS.
|
What is the DCO? (I submitted the other pull request you requested).
…On Mon, May 15, 2023 at 10:02 AM Markus Storm ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Could you please also remove install & uninstall options from menu.bash ?
If possible, also please fix the DCO.
Thank you.
—
Reply to this email directly, view it on GitHub
<#1775 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADEQZL425FY7X7QRONJVBDDXGJHQJANCNFSM6AAAAAAYATFFN4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
George Hyde
Mobile +1-281-620-3039
|
mstormi
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have reported that NTP fails on the Pi installations due to systemd-timesyncd excess start attempts.
It appears that standard Raspberry Pi OS now includes NTP by default and the NTP setup in openHABian set up results in a second daemon, that cannot run because there is already one running.
This PR removes the call from openhabian-setup.sh and the routine from functions/system.bash.